lkml.org 
[lkml]   [2014]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 03/12] tpm: TPM2 support for tpm_pcr_read()
Date
Am Mittwoch, 24. September 2014, 21:43:23 schrieb Jarkko Sakkinen:
> On Wed, Sep 24, 2014 at 10:53:20AM -0600, Jason Gunthorpe wrote:
> > On Wed, Sep 24, 2014 at 12:05:53PM +0300, Jarkko Sakkinen wrote:
> > > +static struct tpm_input_header tpm2_pcrread_header = {
> >
> > Missing const - all of these static structures in tpm2-cmds.c are missing
> > the const, please fix them all.
> >
> > > + .tag = cpu_to_be16(TPM2_ST_NO_SESSIONS),
> > > + .length = cpu_to_be32(TPM2_PCR_READ_IN_SIZE),
> > > + .ordinal = cpu_to_be32(TPM2_CC_PCR_READ)
> > > +};
> >
> > BTW, I always thought this was a goofy and very expensive way to store
> > 3 values and zero initialize. If you want to do something different in
> > the tpm2-cmds.c that would be great too...
>
> What do you think about the way trusted module builds messages? It's easier
> to maintain and debug than the approach used in the tpm subsystem.


Can you post an example (e.g. for the command stream above)

Peter


\
 
 \ /
  Last update: 2014-09-24 22:21    [W:0.058 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site