Messages in this thread | | | Date | Mon, 22 Sep 2014 12:03:45 -0600 | From | Jason Gunthorpe <> | Subject | Re: [tpmdd-devel] [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad |
| |
On Mon, Sep 22, 2014 at 12:43:27PM -0500, Ashley Lai wrote: > Hi Anton, > > Thanks for the patch. Is this oops easy to recreate? If so could > you give us the steps to reproduce?
This looks like it is probably related to the uninitialization mess in the TPM core (resource held during module unload?). A driver should not have to defend itself against null drvdata, so the BUG makes more sense than the if it is replacing.
Jason
| |