Messages in this thread | | | Date | Wed, 3 Dec 2014 08:20:08 +1100 | From | Anton Blanchard <> | Subject | Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad |
| |
Hi,
> is this patchset still needed after Vicky's patch > "[tpmdd-devel] Fix NULL return in tpm_ibmvtpm_get_desired_dma" > https://patchwork.ozlabs.org/patch/402315/ > > Ashley raised some concerns. > > Since merge window is coming up, a fast reply is appreciated.
We definitely need a way to catch an invalid driver data pointer, but it looks like that needs to be reworked after Vicky's patch.
Vicky could you look at all uses of ibmvtpm_get_data and make sure we don't blindly dereference it? eg:
static int tpm_ibmvtpm_resume(struct device *dev) { struct ibmvtpm_dev *ibmvtpm = ibmvtpm_get_data(dev); ...
rc = plpar_hcall_norets(H_ENABLE_CRQ, ibmvtpm->vdev->unit_address);
Anton
| |