Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Add --strict test for concatenated string elements | From | Joe Perches <> | Date | Mon, 01 Sep 2014 10:33:02 -0700 |
| |
Using a space between concatenated string elements is easier for a human to read.
ie: "String"FOO"bar"
is easier to read as:
"String" FOO "bar"
So suggest this style with a --strict command line option.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d89857d..48a2d8c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -4335,6 +4335,12 @@ sub process { "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr); } +# concatenated string without spaces between elements + if ($line =~ /"X+"[A-Z_]+/ || $line =~ /[A-Z_]+"X+"/) { + CHK("CONCATENATED_STRING", + "Concatenated strings should use spaces between elements\n" . $herecurr); + } + # warn about #if 0 if ($line =~ /^.\s*\#\s*if\s+0\b/) { CHK("REDUNDANT_CODE",
| |