Messages in this thread | | | Date | Mon, 4 Aug 2014 04:08:44 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH V3] Save command pool address of Scsi_Host |
| |
On Mon, Aug 04, 2014 at 06:26:09AM +0200, jgross@suse.com wrote: > From: Juergen Gross <jgross@suse.com> > > If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's > private command pool is needed. scsi_find_host_cmd_pool() will locate it, but > scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template. > > This will result in an access error when the host is removed. > > Avoid the problem by saving the address of a new allocated command pool where > it is expected and delete it again when the pool is destroyed.
I don't really like the double pointer passing - just NULLing out the pointer in the caller where needed seems cleaner.
Otherwise this looks good to me.
| |