lkml.org 
[lkml]   [2014]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3] Save command pool address of Scsi_Host
On 08/04/2014 01:08 PM, Christoph Hellwig wrote:
> On Mon, Aug 04, 2014 at 06:26:09AM +0200, jgross@suse.com wrote:
>> From: Juergen Gross <jgross@suse.com>
>>
>> If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's
>> private command pool is needed. scsi_find_host_cmd_pool() will locate it, but
>> scsi_alloc_host_cmd_pool() isn't saving the pool address in the host template.
>>
>> This will result in an access error when the host is removed.
>>
>> Avoid the problem by saving the address of a new allocated command pool where
>> it is expected and delete it again when the pool is destroyed.
>
> I don't really like the double pointer passing - just NULLing out the
> pointer in the caller where needed seems cleaner.

I wanted to avoid to spread this, but I don't mind doing it. V4 is
coming...


Juergen



\
 
 \ /
  Last update: 2014-08-04 13:41    [W:0.056 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site