Messages in this thread Patch in this message | | | From | Rob Jones <> | Subject | [PATCH 4/4] lib: Use seq_open_private() instead of seq_open() | Date | Fri, 29 Aug 2014 17:06:40 +0100 |
| |
Using seq_open_private() removes boilerplate code from ddebug_proc_open()
The resultant code is shorter and easier to follow.
This patch does not change any functionality.
Signed-off-by: Rob Jones <rob.jones@codethink.co.uk> --- lib/dynamic_debug.c | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-)
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c index 7288e38..e067fb5 100644 --- a/lib/dynamic_debug.c +++ b/lib/dynamic_debug.c @@ -827,22 +827,9 @@ static const struct seq_operations ddebug_proc_seqops = { */ static int ddebug_proc_open(struct inode *inode, struct file *file) { - struct ddebug_iter *iter; - int err; - vpr_info("called\n"); - - iter = kzalloc(sizeof(*iter), GFP_KERNEL); - if (iter == NULL) - return -ENOMEM; - - err = seq_open(file, &ddebug_proc_seqops); - if (err) { - kfree(iter); - return err; - } - ((struct seq_file *)file->private_data)->private = iter; - return 0; + return seq_open_private(file, &ddebug_proc_seqops, + sizeof(struct ddebug_iter)); } static const struct file_operations ddebug_proc_fops = { -- 1.7.10.4
| |