Messages in this thread | | | Date | Mon, 01 Sep 2014 13:47:10 +0100 | From | Rob Jones <> | Subject | Re: [PATCH 0/4] Tidy up of modules using seq_open() |
| |
On 29/08/14 20:14, Andrew Morton wrote: > On Fri, 29 Aug 2014 17:06:36 +0100 Rob Jones <rob.jones@codethink.co.uk> wrote: > >> Many modules use seq_open() when seq_open_private() or >> __seq_open_private() would be more appropriate and result in >> simpler, cleaner code. >> >> This patch sequence changes those instances in IPC, MM and LIB. > > Looks good to me. > > I can't begin to imagine why we added the global, exported-to-modules > seq_open_private() without bothering to document it, so any time you > feel like adding the missing kerneldoc...
Already done, I waited for that to be accepted before I submitted this patch :-)
> > And psize should have been size_t, ho hum.
I'll fix that while I'm in the vicinity.
> >
-- Rob Jones Codethink Ltd mailto:rob.jones@codethink.co.uk tel:+44 161 236 5575
| |