lkml.org 
[lkml]   [2014]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/4] mmc: mmci: move block size validation under relevant code


On 19/08/14 12:55, Ulf Hansson wrote:
>> writel(host->size, base + MMCIDATALENGTH);
>> >
>> >- blksz_bits = ffs(data->blksz) - 1;
>> >- BUG_ON(1 << blksz_bits != data->blksz);
> I don't like this BUG_ON at all, I would prefer if we remove it. The
> original patch "mmc: mmci: Support any block sizes for ux500v2", did
> so as well.
>
Yes, you are right this is redundant check, mmci_validate_data in
mmci_request should catch this error anyway. we can remove this check
totally and use your original patch.


--srini
> Now, if we still think removing it is fragile, let additional tests in
> mmci_validate_data() and return and error code from there.


\
 
 \ /
  Last update: 2014-08-19 14:21    [W:0.094 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site