| From | Greg Kroah-Hartman <> | Subject | [PATCH 3.15 069/122] twl4030-madc: Request processed values in twl4030_get_madc_conversion | Date | Mon, 7 Jul 2014 16:57:11 -0700 |
| |
3.15-stable review patch. If anyone has any objections, please let me know.
------------------
From: Paul Kocialkowski <contact@paulk.fr>
commit e0326be0cded13dfc3a24cbeece1f1ae64348a0e upstream.
Not setting the raw parameter in the request causes it to be randomly initialized to a value that might be different from zero or zero. This leads to values that are randomly either raw or processed, making it very difficult to make reliable use of the values.
Signed-off-by: Paul Kocialkowski <contact@paulk.fr> Acked-by: Sebastian Reichel <sre@kernel.org> Signed-off-by: Jonathan Cameron <jic23@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/iio/adc/twl4030-madc.c | 1 + 1 file changed, 1 insertion(+)
--- a/drivers/iio/adc/twl4030-madc.c +++ b/drivers/iio/adc/twl4030-madc.c @@ -645,6 +645,7 @@ int twl4030_get_madc_conversion(int chan req.channels = (1 << channel_no); req.method = TWL4030_MADC_SW2; req.active = 0; + req.raw = 0; req.func_cb = NULL; ret = twl4030_madc_conversion(&req); if (ret < 0)
|