lkml.org 
[lkml]   [2014]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.15 088/122] iommu/vt-d: fix bug in handling multiple RMRRs for the same PCI device
    Date
    3.15-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jiang Liu <jiang.liu@linux.intel.com>

    commit 27e249501ca06a3010519c306206cc402b61b5ab upstream.

    Function dmar_iommu_notify_scope_dev() makes a wrong assumption that
    there's one RMRR for each PCI device at most, which causes DMA failure
    on some HP platforms. So enhance dmar_iommu_notify_scope_dev() to
    handle multiple RMRRs for the same PCI device.

    Fixbug: https://bugzilla.novell.com/show_bug.cgi?id=879482

    Reported-by: Tom Mingarelli <thomas.mingarelli@hp.com>
    Tested-by: Linda Knippers <linda.knippers@hp.com>
    Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
    Signed-off-by: Joerg Roedel <jroedel@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/iommu/intel-iommu.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    --- a/drivers/iommu/intel-iommu.c
    +++ b/drivers/iommu/intel-iommu.c
    @@ -3799,14 +3799,11 @@ int dmar_iommu_notify_scope_dev(struct d
    ((void *)rmrr) + rmrr->header.length,
    rmrr->segment, rmrru->devices,
    rmrru->devices_cnt);
    - if (ret > 0)
    - break;
    - else if(ret < 0)
    + if(ret < 0)
    return ret;
    } else if (info->event == BUS_NOTIFY_DEL_DEVICE) {
    - if (dmar_remove_dev_scope(info, rmrr->segment,
    - rmrru->devices, rmrru->devices_cnt))
    - break;
    + dmar_remove_dev_scope(info, rmrr->segment,
    + rmrru->devices, rmrru->devices_cnt);
    }
    }




    \
     
     \ /
      Last update: 2014-07-08 04:01    [W:2.149 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site