Messages in this thread | | | Date | Thu, 17 Jul 2014 17:38:38 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH] checkpatch.pl: Remove --file option |
| |
On Thu, Jul 17, 2014 at 05:34:28PM +0200, Richard Weinberger wrote: > checkpatch.pl is a nice tool to find issues in patches. > Sadly this tool gets more and more abused by various people to create > style cleanups for source files within the kernel. > In order to deal with that bad habit let's remove the --file option > and bring checkpatch.pl back to its original purpose. > > Suggested-by: NeilBrown <neilb@suse.de> > Signed-off-by: Richard Weinberger <richard@nod.at>
Very good idea:
Acked-by: Borislav Petkov <bp@suse.de>
You could also make it do:
if ($file) { print STDERR "Go find real bugs in the kernel instead!\n"; exit(-1); }
if someone supplies --file on the cmdline.
-- Regards/Gruss, Boris.
Sent from a fat crate under my desk. Formatting is fine. --
| |