lkml.org 
[lkml]   [2014]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] checkpatch.pl: Remove --file option
On Thu, Jul 17, 2014 at 05:34:28PM +0200, Richard Weinberger wrote:
> checkpatch.pl is a nice tool to find issues in patches.
> Sadly this tool gets more and more abused by various people to create
> style cleanups for source files within the kernel.
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.
>
> Suggested-by: NeilBrown <neilb@suse.de>
> Signed-off-by: Richard Weinberger <richard@nod.at>

Very good idea:

Acked-by: Borislav Petkov <bp@suse.de>

You could also make it do:

if ($file) {
print STDERR "Go find real bugs in the kernel instead!\n";
exit(-1);
}

if someone supplies --file on the cmdline.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-07-17 18:41    [W:0.141 / U:0.752 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site