lkml.org 
[lkml]   [2014]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch.pl: Remove --file option
From
Date
On Thu, 2014-07-17 at 17:34 +0200, Richard Weinberger wrote:
> checkpatch.pl is a nice tool to find issues in patches.

grep is a similar tool, just less automated.

> Sadly this tool gets more and more abused by various people to create
> style cleanups for source files within the kernel.
> In order to deal with that bad habit let's remove the --file option
> and bring checkpatch.pl back to its original purpose.

Any tool can be misused.

diff -urN /dev/null $file | ./scripts/checkpatch.pl -

does the same thing as --file so I don't see any real
fundamental difference.

I think it should really only be used in --file mode
on drivers/staging/.

I wouldn't mind adding some additional "yes, I really
mean to do this" cmd-line flag when it's used on any
file outside of staging with some additional warning
that "--file" is discouraged outside of staging when
it's not there.

But additional documentation only goes so far.




\
 
 \ /
  Last update: 2014-07-17 18:22    [W:0.143 / U:6.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site