Messages in this thread | | | Date | Tue, 15 Jul 2014 18:05:35 +0900 | Subject | Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile() | From | DaeSeok Youn <> |
| |
2014-07-15 15:51 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>: > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: >> The p->u.board.status is allocated and set a string as >> "No" once within allocating a node of BNODE type. >> But it also set again with kstrdup() in case of "STATUS" >> or "ID". If it is not allocated yet, use kstrdup(). >> If not, use just memcpy(). > > I don't think a 2 char buffer is always large enough to hold the new > strings. > > Just free it and allocate again. Yes, I will send this again.
Thanks.
regards, Daeseok Youn. > > regards, > dan carpenter >
| |