Messages in this thread | | | Date | Tue, 15 Jul 2014 18:45:18 +0900 | Subject | Re: [PATCH 8/8] staging: dgap: fix memory leak in dgap_parsefile() | From | DaeSeok Youn <> |
| |
2014-07-15 18:21 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>: > On Tue, Jul 15, 2014 at 06:05:35PM +0900, DaeSeok Youn wrote: >> 2014-07-15 15:51 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>: >> > On Tue, Jul 15, 2014 at 12:05:14PM +0900, Daeseok Youn wrote: >> >> The p->u.board.status is allocated and set a string as >> >> "No" once within allocating a node of BNODE type. >> >> But it also set again with kstrdup() in case of "STATUS" >> >> or "ID". If it is not allocated yet, use kstrdup(). >> >> If not, use just memcpy(). >> > >> > I don't think a 2 char buffer is always large enough to hold the new >> > strings. >> > >> > Just free it and allocate again. >> Yes, I will send this again. >> > > Actually, please just send the whole set again. I really want Mark on > the CC list so he's reviewing these. OK. I already sent 6/8, 7/8 and 8/8 again. I just resend rest of them.
thanks.
regards, Daeseok Youn > > regards, > dan carpenter >
| |