Messages in this thread | | | Date | Mon, 30 Jun 2014 22:27:18 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 2/4] uprobes: Change unregister/apply to WARN() if uprobe/consumer is gone |
| |
* Oleg Nesterov <oleg@redhat.com> [2014-06-27 19:01:40]:
> Add WARN_ON's into uprobe_unregister() and uprobe_apply() to ensure > that nobody tries to play with the dead uprobe/consumer. This helps > to catch the bugs like the one fixed by the previous patch. > > In the longer term we should fix this poorly designed interface. > uprobe_register() should return "struct uprobe *" which should be > passed to apply/unregister. Plus other semantic changes, see the > changelog in commit 41ccba029e94. > > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
-- Thanks and Regards Srikar Dronamraju
| |