lkml.org 
[lkml]   [2014]   [Jun]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] tracing/uprobes: Fix the usage of uprobe_buffer_enable() in probe_event_enable()
> The usage of uprobe_buffer_enable() added by dcad1a20 is very wrong,
>
> 1. uprobe_buffer_enable() and uprobe_buffer_disable() are not balanced,
> _enable() should be called only if !enabled.
>
> 2. If uprobe_buffer_enable() fails probe_event_enable() should clear
> tp.flags and free event_file_link.
>
> 3. If uprobe_register() fails it should do uprobe_buffer_disable().
>
> Signed-off-by: Oleg Nesterov <oleg@redhat.com>

Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
(one nit .. )

> + ret = uprobe_buffer_enable();
> + if (ret)
> + goto err_flags;
> +
> tu->consumer.filter = filter;
> ret = uprobe_register(tu->inode, tu->offset, &tu->consumer);
> - if (ret) {
> - if (file) {
> - list_del(&link->list);
> - kfree(link);
> - tu->tp.flags &= ~TP_FLAG_TRACE;
> - } else
> - tu->tp.flags &= ~TP_FLAG_PROFILE;
> - }
> + if (ret)
> + goto err_buffer;
>
> + return 0;
> +
> + err_buffer:
> + uprobe_buffer_disable();
> +

How about avoiding err_buffer label?
+ if (!ret)
+ return 0;

+ uprobe_buffer_disable();
+


> + err_flags:
> + if (file) {
> + list_del(&link->list);
>
> --
> 1.5.5.1
>

--
Thanks and Regards
Srikar Dronamraju



\
 
 \ /
  Last update: 2014-06-30 19:41    [W:0.236 / U:12.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site