lkml.org 
[lkml]   [2014]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tulip: Poll link status more frequently for Comet chips
From
Hi Ondrej,

On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary <linux@rainbow-software.org> wrote:
> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.

Why use 2 seconds for the polling interval?

I'm sure you have a good reason for this and it should be in the
commit message or as a comment in the code.

I otherwise have no objection to this change.

thanks,
grant

> Tested with AN983B.
>
> Signed-off-by: Ondrej Zary <linux@rainbow-software.org>
> ---
> drivers/net/ethernet/dec/tulip/timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/timer.c b/drivers/net/ethernet/dec/tulip/timer.c
> index 768379b..523d9dd 100644
> --- a/drivers/net/ethernet/dec/tulip/timer.c
> +++ b/drivers/net/ethernet/dec/tulip/timer.c
> @@ -158,7 +158,7 @@ void comet_timer(unsigned long data)
> {
> struct net_device *dev = (struct net_device *)data;
> struct tulip_private *tp = netdev_priv(dev);
> - int next_tick = 60*HZ;
> + int next_tick = 2*HZ;
>
> if (tulip_debug > 1)
> netdev_dbg(dev, "Comet link status %04x partner capability %04x\n",
> --
> Ondrej Zary


\
 
 \ /
  Last update: 2014-06-22 01:21    [W:0.039 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site