lkml.org 
[lkml]   [2014]   [Jun]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] tulip: Poll link status more frequently for Comet chips
From
From: Grant Grundler <grantgrundler@gmail.com>
Date: Sat, 21 Jun 2014 15:59:30 -0700

> Hi Ondrej,
>
> On Sat, Jun 21, 2014 at 1:29 PM, Ondrej Zary <linux@rainbow-software.org> wrote:
>> Poll link status every 2 seconds instead of 60 for ADMtek Comet chips.
>
> Why use 2 seconds for the polling interval?
>
> I'm sure you have a good reason for this and it should be in the
> commit message or as a comment in the code.
>
> I otherwise have no objection to this change.

Agreed, please post this with a better commit message, specifically
make sure you explain why the interval is being changed and why
2*HZ is specifically being choosen.

Thanks.


\
 
 \ /
  Last update: 2014-06-22 05:01    [W:0.040 / U:29.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site