lkml.org 
[lkml]   [2014]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: regulator: bcm590xx: Add support for regulators on secondary I2C slave
On Tue, Jun 03, 2014 at 07:29:10PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=c6466950e917890be3050171f6745ccb9d91d35f
> Commit: c6466950e917890be3050171f6745ccb9d91d35f
> Parent: 9e1e726311830bc5b8b568d5178f6a52c357fb6e
> Refname: refs/heads/next
> Author: Matt Porter <mporter@linaro.org>
> AuthorDate: Wed Apr 23 19:21:32 2014 -0400
> Committer: Lee Jones <lee.jones@linaro.org>
> CommitDate: Wed May 21 10:40:16 2014 +0100
>
> regulator: bcm590xx: Add support for regulators on secondary I2C slave
>
> The bcm590xx MFD driver now exposes a secondary regmap descriptor
> making the registers for regulators on the secondary I2C slave address
> available. Add support for GPLDO1-6 and VBUS regulators found within
> this register range.

> -#define BCM590XX_NUM_REGS 20
> +#define BCM590XX_NUM_REGS 27

Coverity picked up that this change has introduced a out of bounds read.
The loop in bcm590xx_probe iterates from 0 to NUM_REGS,
but the bcm590xx_regs struct it iterates over using the ptr 'info' is only 26
elements.

Dave



\
 
 \ /
  Last update: 2014-06-10 18:01    [W:0.163 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site