Messages in this thread Patch in this message | | | From | Dongsheng Yang <> | Subject | [PATCH] sched: Use clamp() and clamp_val() to make it more readable. | Date | Thu, 8 May 2014 18:35:15 +0900 |
| |
As Kees suggested, I use clamp() function to replace the if and else branch, making it more readable and modular.
Suggested-by: Kees Cook <keescook@chromium.org> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> --- kernel/sched/core.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c index ff871f5..79f8638 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -3039,17 +3039,10 @@ SYSCALL_DEFINE1(nice, int, increment) * We don't have to worry. Conceptually one call occurs first * and we have a single winner. */ - if (increment < -40) - increment = -40; - if (increment > 40) - increment = 40; - + increment = clamp(increment, -NICE_WIDTH, NICE_WIDTH); nice = task_nice(current) + increment; - if (nice < MIN_NICE) - nice = MIN_NICE; - if (nice > MAX_NICE) - nice = MAX_NICE; + nice = clamp_val(nice, MIN_NICE, MAX_NICE); if (increment < 0 && !can_nice(current, nice)) return -EPERM; -- 1.8.2.1
| |