lkml.org 
[lkml]   [2014]   [May]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync
Hi Julia,

> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Use del_timer_sync to ensure that the timer is stopped on all CPUs before
> the driver exits.
>
> This change was suggested by Thomas Gleixner.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r@
> identifier i,t,ex;
> @@
> struct t i = { .remove = ex, };
>
> @@
> identifier r.ex;
> @@
> ex(...) {
> <...
> - del_timer
> + del_timer_sync
> (...)
> ...>
> }
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> Not tested.
>
> drivers/watchdog/via_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/via_wdt.c b/drivers/watchdog/via_wdt.c
> index d2cd9f0..56369c4 100644
> --- a/drivers/watchdog/via_wdt.c
> +++ b/drivers/watchdog/via_wdt.c
> @@ -232,7 +232,7 @@ err_out_disable_device:
> static void wdt_remove(struct pci_dev *pdev)
> {
> watchdog_unregister_device(&wdt_dev);
> - del_timer(&timer);
> + del_timer_sync(&timer);
> iounmap(wdt_mem);
> release_mem_region(mmio, VIA_WDT_MMIO_LEN);
> release_resource(&wdt_res);
>

This was added 2 or 3 weeks ago to linux-watchdog-next.

Kind regards,
Wim.



\
 
 \ /
  Last update: 2014-05-26 22:01    [W:0.132 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site