Messages in this thread Patch in this message | | | From | Julia Lawall <> | Subject | [PATCH 2/3] ray_cs: replace del_timer by del_timer_sync | Date | Tue, 1 Apr 2014 15:49:18 +0200 |
| |
From: Julia Lawall <Julia.Lawall@lip6.fr>
Use del_timer_sync to ensure that the timer is stopped on all CPUs before the driver exits.
This change was suggested by Thomas Gleixner.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @r@ identifier i,t,ex; @@ struct t i = { .remove = ex, };
@@ identifier r.ex; @@ ex(...) { <... - del_timer + del_timer_sync (...) ...> } // </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
--- Not tested.
drivers/net/wireless/ray_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/ray_cs.c b/drivers/net/wireless/ray_cs.c index cbf0a58..8330fa3 100644 --- a/drivers/net/wireless/ray_cs.c +++ b/drivers/net/wireless/ray_cs.c @@ -343,7 +343,7 @@ static void ray_detach(struct pcmcia_device *link) ray_release(link); local = netdev_priv(dev); - del_timer(&local->timer); + del_timer_sync(&local->timer); if (link->priv) { unregister_netdev(dev);
| |