Messages in this thread | | | Date | Mon, 26 May 2014 18:10:28 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function. |
| |
On 26/05/14 15:34, Ulf Hansson wrote: > This is hot path. > > As I suggested for the readl and writel wrapper functions, I think it > would be better to use a function pointer in the struct mmci host, > which you set up in the probe phase. That means the variant data don't > need to be checked each an every time this function gets invoked. > >> >+ >> > if (status & MCI_TXACTIVE) >> > len = mmci_pio_write(host, buffer, remain, status); > So no changes needed for pio_write at this point? Or those will come later? >
Yes, that sounds like more sensible approach to me. I will do this change in next version.
Thanks, srini >> > >> >--
| |