Messages in this thread | | | Date | Wed, 28 May 2014 09:51:59 +0100 | From | Srinivas Kandagatla <> | Subject | Re: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function. |
| |
On 28/05/14 09:08, Linus Walleij wrote: > On Fri, May 23, 2014 at 2:53 PM, <srinivas.kandagatla@linaro.org> wrote: > >> + if (unlikely(bytes)) { >> + unsigned char buf[4]; > (...)
> > Please think twice about this. > http://lwn.net/Articles/70473/ > http://lwn.net/Articles/420019/ > http://lwn.net/Articles/182369/ > Thanks for the warning.
You are right. I think having likely/unlikely is not always right here.
thanks, srini > Yours, > Linus Walleij >
| |