lkml.org 
[lkml]   [2014]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3 13/13] mmc: mmci: Add Qcom specific pio_read function.


    On 28/05/14 09:08, Linus Walleij wrote:
    > On Fri, May 23, 2014 at 2:53 PM, <srinivas.kandagatla@linaro.org> wrote:
    >
    >> + if (unlikely(bytes)) {
    >> + unsigned char buf[4];
    > (...)

    >
    > Please think twice about this.
    > http://lwn.net/Articles/70473/
    > http://lwn.net/Articles/420019/
    > http://lwn.net/Articles/182369/
    >
    Thanks for the warning.

    You are right. I think having likely/unlikely is not always right here.

    thanks,
    srini
    > Yours,
    > Linus Walleij
    >


    \
     
     \ /
      Last update: 2014-05-28 11:21    [W:5.394 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site