lkml.org 
[lkml]   [2014]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM / OPP: discard duplicate OPP additions
On 05/14/2014 06:08 AM, Viresh Kumar wrote:
> On 14 May 2014 15:01, Chander Kashyap <chander.kashyap@linaro.org> wrote:
>>> say we do at this point:
>>> if (new_opp->rate == opp->rate) {
>>> dev_err(dev, "%s: attempt to add duplicate OPP entry (rate=%ld)\n",
>>> __func__, new_opp->rate)
>>> kfree(new_opp);
>>> return -EINVAL;
>>> }
>>
>> Yes this is more cleaner.
>> But instead of dev_err, we should use dev_warn and secondly
>
> Correct
>
>> return 0 rather than EINVAL, as there are independent users for this function
>
> Why? We should actually use EEXIST here instead of EINVAL though..
>
Yep -EEXIST is the right return value here. As Viresh indicated,
reporting back 0 when the requested operation actually was not
performed is wrong. Caller is supposed to know when it makes an error
- hiding it is not correct.

--
Regards,
Nishanth Menon


\
 
 \ /
  Last update: 2014-05-17 18:41    [W:0.273 / U:0.852 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site