Messages in this thread | | | Date | Wed, 14 May 2014 16:38:10 +0530 | Subject | Re: [PATCH] PM / OPP: discard duplicate OPP additions | From | Viresh Kumar <> |
| |
On 14 May 2014 15:01, Chander Kashyap <chander.kashyap@linaro.org> wrote: >> say we do at this point: >> if (new_opp->rate == opp->rate) { >> dev_err(dev, "%s: attempt to add duplicate OPP entry (rate=%ld)\n", >> __func__, new_opp->rate) >> kfree(new_opp); >> return -EINVAL; >> } > > Yes this is more cleaner. > But instead of dev_err, we should use dev_warn and secondly
Correct
> return 0 rather than EINVAL, as there are independent users for this function
Why? We should actually use EEXIST here instead of EINVAL though..
| |