lkml.org 
[lkml]   [2014]   [Apr]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 06/20] c6x: convert fdt pointers to opaque pointers
From
Hi Rob,

On Fri, Apr 4, 2014 at 12:16 AM, Rob Herring <robherring2@gmail.com> wrote:
> --- a/arch/c6x/kernel/setup.c
> +++ b/arch/c6x/kernel/setup.c
> @@ -265,8 +265,8 @@ int __init c6x_add_memory(phys_addr_t start, unsigned long size)
> */
> notrace void __init machine_init(unsigned long dt_ptr)
> {
> - struct boot_param_header *dtb = __va(dt_ptr);
> - struct boot_param_header *fdt = (struct boot_param_header *)_fdt_start;
> + const void *dtb = __va(dt_ptr);
> + const void *fdt = (const void *)_fdt_start;

Unless it has changed recently, _fdt_start is "char _fdt_start[]",
so the cast should not be needed.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2014-04-04 12:41    [W:0.237 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site