lkml.org 
[lkml]   [2014]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support
Date

> > Now for the following scenarios:
> >
> > SoC | CPU | FTM-PWM | 'big-endian' property is needed?
> > -------------|--------|---------|---------------------------------
> > Vybird | LE | LE | No
> > LS1 | LE | BE | Yes
> > LS2 | LE | LE | No
> >
> > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> > ---
> > drivers/pwm/pwm-fsl-ftm.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
>
> And this should probably describe in text what happens. The table may
> look good, but you don't give a real description of what the change
> does.
>

I will follow your advice.


> Oh, and doesn't this change need to update the device tree binding since
> you now have an additional property?
>

Yes, you are right. I just forgot it.

I will add update it.

Thanks very much.

BRs
XIubo



\
 
 \ /
  Last update: 2014-04-28 18:01    [W:0.197 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site