Messages in this thread | | | From | "" <> | Subject | RE: [PATCH 3/3] pwm: ftm-pwm: Add big-endian support | Date | Mon, 28 Apr 2014 15:11:11 +0000 |
| |
> > Now for the following scenarios: > > > > SoC | CPU | FTM-PWM | 'big-endian' property is needed? > > -------------|--------|---------|--------------------------------- > > Vybird | LE | LE | No > > LS1 | LE | BE | Yes > > LS2 | LE | LE | No > > > > Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com> > > --- > > drivers/pwm/pwm-fsl-ftm.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > And this should probably describe in text what happens. The table may > look good, but you don't give a real description of what the change > does. >
I will follow your advice.
> Oh, and doesn't this change need to update the device tree binding since > you now have an additional property? >
Yes, you are right. I just forgot it.
I will add update it.
Thanks very much.
BRs XIubo
| |