lkml.org 
[lkml]   [2014]   [Apr]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] pwm: ftm-pwm: Convert to direct regmap API usage.
On Fri, Mar 21, 2014 at 12:53:09PM +0800, Xiubo Li wrote:
> Signed-off-by: Xiubo Li <Li.Xiubo@freescale.com>
> ---
> drivers/pwm/pwm-fsl-ftm.c | 83 +++++++++++++++++++++++++----------------------
> 1 file changed, 44 insertions(+), 39 deletions(-)

This could explain the advantages of converting to regmap. Looking at
this diffstat above, it's not immediately obvious that there's an
advantage because you end up adding 5 lines.

Again I'm guessing this is in preparation to add endianess support, and
it will be really easy to add that using regmap, so the gains will only
become obvious later on.

That's the kind of thing I'd like to see in the patch description. It
tells me why this patch makes sense.

Thierry
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-04-28 18:21    [W:0.185 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site