lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: uart: add hw flow control support configuration
On Wed, Apr 23, 2014 at 03:27:17PM +0100, One Thousand Gnomes wrote:
> > >- if (up->capabilities & UART_CAP_AFE && port->fifosize >= 32) {
> > >+ if ((up->capabilities & UART_CAP_AFE && (port->fifosize >= 32)) ||
> > >+ port->flags & UPF_HARD_FLOW) {
> >
> > [Alan] Surely you want brackets on the port->flags & UPF_HARD_FLOW ??
> >
> > The C precedence table shows following order:=
> > -> & ||
> >
> > So flags will be accessed first and then AND-ed with UPF_HARD_FLOW and
> > result will be OR-ed with left side expression value. So no need for bracket IMO.
>
> Yep... agreed.

Perhaps, but please put them there so we all _know_ what it is doing is
correct.

greg k-h


\
 
 \ /
  Last update: 2014-04-25 01:41    [W:0.493 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site