Messages in this thread | | | Date | Wed, 23 Apr 2014 15:27:17 +0100 | From | One Thousand Gnomes <> | Subject | Re: [PATCH] serial: uart: add hw flow control support configuration |
| |
> >- if (up->capabilities & UART_CAP_AFE && port->fifosize >= 32) { > >+ if ((up->capabilities & UART_CAP_AFE && (port->fifosize >= 32)) || > >+ port->flags & UPF_HARD_FLOW) { > > [Alan] Surely you want brackets on the port->flags & UPF_HARD_FLOW ?? > > The C precedence table shows following order:= > -> & || > > So flags will be accessed first and then AND-ed with UPF_HARD_FLOW and > result will be OR-ed with left side expression value. So no need for bracket IMO.
Yep... agreed.
Alan
| |