lkml.org 
[lkml]   [2014]   [Apr]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] serial: uart: add hw flow control support configuration
> >-	if (up->capabilities & UART_CAP_AFE && port->fifosize >= 32) {
> >+ if ((up->capabilities & UART_CAP_AFE && (port->fifosize >= 32)) ||
> >+ port->flags & UPF_HARD_FLOW) {
>
> [Alan] Surely you want brackets on the port->flags & UPF_HARD_FLOW ??
>
> The C precedence table shows following order:=
> -> & ||
>
> So flags will be accessed first and then AND-ed with UPF_HARD_FLOW and
> result will be OR-ed with left side expression value. So no need for bracket IMO.

Yep... agreed.

Alan


\
 
 \ /
  Last update: 2014-04-23 16:41    [W:0.102 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site