Messages in this thread | | | Date | Thu, 24 Apr 2014 14:27:21 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply() |
| |
On 04/24, Srikar Dronamraju wrote: > > Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Thanks, included!
> > + tu->filter.nr_systemwide--; > > done = tu->filter.nr_systemwide; > > - tu->filter.nr_systemwide++; > > } > > Nit: I think 2 lines can be made into > done = --tu->filter.nr_systemwide; ... > > - tu->filter.nr_systemwide--; > > done = tu->filter.nr_systemwide; > > + tu->filter.nr_systemwide++; > > } > > Nit: Similarly lines can be made into > done = tu->filter.nr_systemwide++;
Yes, perhaps, but this has nothing to do with this patch, it does not change this code.
And can't resist... you know, initially I wrote this code this way, but then I decided to make it more straightforward to avoid the potential nits from reviewers ;)
Oleg.
| |