lkml.org 
[lkml]   [2014]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply()
On 04/24, Srikar Dronamraju wrote:
>
> Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

Thanks, included!

> > + tu->filter.nr_systemwide--;
> > done = tu->filter.nr_systemwide;
> > - tu->filter.nr_systemwide++;
> > }
>
> Nit: I think 2 lines can be made into
> done = --tu->filter.nr_systemwide;
...
> > - tu->filter.nr_systemwide--;
> > done = tu->filter.nr_systemwide;
> > + tu->filter.nr_systemwide++;
> > }
>
> Nit: Similarly lines can be made into
> done = tu->filter.nr_systemwide++;

Yes, perhaps, but this has nothing to do with this patch, it does not
change this code.

And can't resist... you know, initially I wrote this code this way, but
then I decided to make it more straightforward to avoid the potential nits
from reviewers ;)

Oleg.



\
 
 \ /
  Last update: 2014-04-24 15:01    [W:0.083 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site