Messages in this thread | | | Date | Thu, 24 Apr 2014 14:33:41 +0530 | From | Srikar Dronamraju <> | Subject | Re: [PATCH 1/1] uprobes/tracing: uprobe_perf_open() forgets to handle the error from uprobe_apply() |
| |
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com> (with 2 nits that you can ignore)
> done = tu->filter.nr_systemwide || > - event->parent || event->attr.enable_on_exec || > + (event->hw.tp_target->flags & PF_EXITING) || > uprobe_filter_event(tu, event); > - list_add(&event->hw.tp_list, &tu->filter.perf_events); > } else { > + tu->filter.nr_systemwide--; > done = tu->filter.nr_systemwide; > - tu->filter.nr_systemwide++; > }
Nit: I think 2 lines can be made into done = --tu->filter.nr_systemwide;
<snipped> > done = tu->filter.nr_systemwide || > - (event->hw.tp_target->flags & PF_EXITING) || > + event->parent || event->attr.enable_on_exec || > uprobe_filter_event(tu, event); > + list_add(&event->hw.tp_list, &tu->filter.perf_events); > } else { > - tu->filter.nr_systemwide--; > done = tu->filter.nr_systemwide; > + tu->filter.nr_systemwide++; > }
Nit: Similarly lines can be made into done = tu->filter.nr_systemwide++;
-- Thanks and Regards Srikar Dronamraju
| |