lkml.org 
[lkml]   [2014]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Resend Patch 3/9] ACPI: Add acpi_bus_attach_private_data() to facilitate to attach data to ACPI handle
On Tue, Apr 22, 2014 at 02:24:09PM +0800, Lan Tianyu wrote:
> There is already acpi_bus_get_private_data() to get ACPI handle data
> which is associated with acpi_bus_private_data_handler(). This patch
> is to add acpi_bus_attach_private_data() to make a pair and facilitate
> to attach and get data to/from ACPI handle.
>
> Signed-off-by: Lan Tianyu <tianyu.lan@intel.com>
> ---
> drivers/acpi/bus.c | 18 +++++++++++++++++-
> include/acpi/acpi_bus.h | 1 +
> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index e7e5844..4ed8d48 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -132,6 +132,22 @@ void acpi_bus_private_data_handler(acpi_handle handle,
> }
> EXPORT_SYMBOL(acpi_bus_private_data_handler);
>
> +int acpi_bus_attach_private_data(acpi_handle handle, void *data)
> +{
> + acpi_status status;
> +
> + status = acpi_attach_data(handle,
> + acpi_bus_private_data_handler, data);
> + if (ACPI_FAILURE(status)) {
> + ACPI_ERROR((AE_INFO, "Error attaching device[%p] data\n",
> + handle));
> + return -ENODEV;
> + }
> +
> + return 0;
> +}
> +EXPORT_SYMBOL(acpi_bus_attach_private_data);

When I added GPIO operation region support, Rafael mentioned that we might
want to add this private data to the struct acpi_device instead.

Either way, looks good to me,

Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>


\
 
 \ /
  Last update: 2014-04-22 13:41    [W:0.357 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site