Messages in this thread | | | Date | Wed, 23 Apr 2014 09:53:21 +0800 | From | Lan Tianyu <> | Subject | Re: [Resend Patch 7/9] I2C/ACPI: Add i2c ACPI operation region support |
| |
Hi Mika: Thanks a lot for your review.
On 2014年04月22日 19:36, Mika Westerberg wrote: >> > + >> > + client.adapter = adapter; >> > + client.addr = sb->slave_address; >> > + client.flags = 0; > I'm not sure if this is the correct way to use struct i2c_client > (allocating it from stack and passing forward to functions that might > expect a real i2c_client structure). It has ->dev and all.
I check all i2c_smbus_xxx helper functions and they are simple wrappers of i2c_smbus_xfer(). Only adapter, addr and flags of struct client are used in these functions.
> > I'm wondering if you can use i2c_transfer() and i2c_smbus_xfer() here > instead, passing just the adapter pointer? >
Yes, I can do that but this needs to copy all codes of i2c_smbus_xxx helper function in the i2c-core.c here. This seems duplicated?
-- Best regards Tianyu Lan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |