Messages in this thread | | | Date | Tue, 22 Apr 2014 09:37:36 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 6/9] drivers/staging/speakup/: avoid world-writable sysfs files. |
| |
On Tue, Apr 22, 2014 at 01:03:29PM +0930, Rusty Russell wrote: > In line with practice for module parameters, we're adding a build-time > check that sysfs files aren't world-writable.
Then why not just use the __ATTR_RO() macro?
> > Cc: Christopher Brannon <chris@the-brannons.com> > Cc: Samuel Thibault <samuel.thibault@ens-lyon.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > --- > drivers/staging/speakup/kobjects.c | 60 ++++++++++++++++---------------- > drivers/staging/speakup/speakup_acntpc.c | 14 ++++---- > drivers/staging/speakup/speakup_acntsa.c | 14 ++++---- > drivers/staging/speakup/speakup_apollo.c | 16 ++++----- > drivers/staging/speakup/speakup_audptr.c | 16 ++++----- > drivers/staging/speakup/speakup_bns.c | 14 ++++---- > drivers/staging/speakup/speakup_decext.c | 16 ++++----- > drivers/staging/speakup/speakup_decpc.c | 16 ++++----- > drivers/staging/speakup/speakup_dectlk.c | 16 ++++----- > drivers/staging/speakup/speakup_dtlk.c | 20 +++++------ > drivers/staging/speakup/speakup_dummy.c | 14 ++++---- > drivers/staging/speakup/speakup_keypc.c | 10 +++--- > drivers/staging/speakup/speakup_ltlk.c | 20 +++++------ > drivers/staging/speakup/speakup_soft.c | 22 ++++++------ > drivers/staging/speakup/speakup_spkout.c | 16 ++++----- > drivers/staging/speakup/speakup_txprt.c | 14 ++++---- > 16 files changed, 149 insertions(+), 149 deletions(-) > > diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c > index 1ca91f7092b1..c4aa13fc2d13 100644 > --- a/drivers/staging/speakup/kobjects.c > +++ b/drivers/staging/speakup/kobjects.c > @@ -853,73 +853,73 @@ static ssize_t message_store(struct kobject *kobj, struct kobj_attribute *attr, > static struct kobj_attribute keymap_attribute = > __ATTR(keymap, S_IWUSR|S_IRUGO, keymap_show, keymap_store); > static struct kobj_attribute silent_attribute = > - __ATTR(silent, S_IWUGO, NULL, silent_store); > + __ATTR(silent, S_IWUSR|S_IWGRP, NULL, silent_store);
__ATTR_WO()?
I'd prefer some "standard" permissions for all of these sysfs files, it's quite confusing otherwise, don't you agree?
thanks
greg k-h
| |