Messages in this thread | | | Date | Fri, 2 May 2014 21:43:54 +0200 | From | Bruno Prémont <> | Subject | Re: [PATCH 7/9] drivers/hid/hid-picolcd_fb: avoid world-writable sysfs files. |
| |
On Tue, 22 April 2014 Rusty Russell <rusty@rustcorp.com.au> wrote: > In line with practice for module parameters, we're adding a build-time > check that sysfs files aren't world-writable. > > Cc: Bruno Prémont <bonbons@linux-vserver.org> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fine with me, Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Not sure which tree you plan to push this through, CCing Jiri as all picoLCD driver went in via HID tree.
> --- > drivers/hid/hid-picolcd_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index c930ab8554ea..7f965e231433 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -501,7 +501,7 @@ static ssize_t picolcd_fb_update_rate_store(struct device *dev, > return count; > } > > -static DEVICE_ATTR(fb_update_rate, 0666, picolcd_fb_update_rate_show, > +static DEVICE_ATTR(fb_update_rate, 0664, picolcd_fb_update_rate_show, > picolcd_fb_update_rate_store); > > /* initialize Framebuffer device */ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |