Messages in this thread Patch in this message | | | Date | Thu, 27 Feb 2014 10:46:18 -0500 | From | Steven Rostedt <> | Subject | [RFA][PATCH 2/5] ftrace/x86: One more missing sync after fixup of function modification failure |
| |
[Request for Ack]
From: Petr Mladek <pmladek@suse.cz>
If a failure occurs while modifying ftrace function, it bails out and will remove the tracepoints to be back to what the code originally was.
There is missing the final sync run across the CPUs after the fix up is done and before the ftrace int3 handler flag is reset.
Link: http://lkml.kernel.org/r/1393258342-29978-2-git-send-email-pmladek@suse.cz
Fixes: 8a4d0a687a5 "ftrace: Use breakpoint method to update ftrace caller" Cc: stable@vger.kernel.org # 3.5+ Signed-off-by: Petr Mladek <pmladek@suse.cz> Signed-off-by: Steven Rostedt <rostedt@goodmis.org> --- arch/x86/kernel/ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c index 6b566c8..69885e2 100644 --- a/arch/x86/kernel/ftrace.c +++ b/arch/x86/kernel/ftrace.c @@ -660,8 +660,8 @@ ftrace_modify_code(unsigned long ip, unsigned const char *old_code, ret = -EPERM; goto out; } - run_sync(); out: + run_sync(); return ret; fail_update: -- 1.8.5.3
| |