lkml.org 
[lkml]   [2014]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFA][PATCH 5/5] tracepoint: Warn and notify if tracepoints are not loaded due to module taint
On Thu, 27 Feb 2014 16:33:50 +0000 (UTC)
Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:

> > - if (trace_module_has_bad_taint(mod))
> > + if (trace_module_has_bad_taint(mod)) {
> > + pr_err("Module '%s' is tainted, disabling tracepoints\n",
>
> Hrm, I wonder if this message could confuse users into thinking that because
> of this error, tracepoints are disabled across the entire kernel (rather than
> within this module).
>
> I'd recommend the following message instead:
>
> pr_err("Module '%s' is tainted, ignoring its tracepoints\n",
>

Sure. Will update.

-- Steve


\
 
 \ /
  Last update: 2014-02-27 18:41    [W:0.176 / U:4.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site