Messages in this thread Patch in this message | | | Subject | Re: [PATCH] Staging: comedi: Fix line length exceeding 80 characters | From | Joe Perches <> | Date | Tue, 25 Feb 2014 01:59:25 -0800 |
| |
On Tue, 2014-02-25 at 09:46 +0000, Ian Abbott wrote: > On 2014-02-24 16:49, Monam Agarwal wrote: [] > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c [] > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev, > > async->cmd.data = NULL; > > /* load channel/gain list */ > > async->cmd.chanlist = memdup_user(user_chanlist, > > - async->cmd.chanlist_len * sizeof(int)); > > + async->cmd.chanlist_len > > + * sizeof(int)); > > The `*` operator should go at the end of the line according to the > CodingStyle.
I don't believe there's a CodingStyle guide for this.
Another way to do this is to move the memdup_user to a separate line like:
async->cmd_chanlist = memdup_user(user_chanlist, async->cmd.chanlist_len * sizeof(int));
but I'm not bothered by the existing > 80 column use.
| |