lkml.org 
[lkml]   [2014]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: comedi: Fix line length exceeding 80 characters
From
Date
On Tue, 2014-02-25 at 14:05 +0300, Dan Carpenter wrote:
> On Tue, Feb 25, 2014 at 01:59:25AM -0800, Joe Perches wrote:
> > On Tue, 2014-02-25 at 09:46 +0000, Ian Abbott wrote:
> > > On 2014-02-24 16:49, Monam Agarwal wrote:
> > []
> > > > diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c
> > []
> > > > @@ -1481,7 +1481,8 @@ static int do_cmd_ioctl(struct comedi_device *dev,
> > > > async->cmd.data = NULL;
> > > > /* load channel/gain list */
> > > > async->cmd.chanlist = memdup_user(user_chanlist,
> > > > - async->cmd.chanlist_len * sizeof(int));
> > > > + async->cmd.chanlist_len
> > > > + * sizeof(int));
> > > The `*` operator should go at the end of the line according to the
> > > CodingStyle.
> > I don't believe there's a CodingStyle guide for this.
> Meanwhile you have felt totally justified in correcting me on this in
> the past. :P

Doubtful. You're probably thinking of something else.

Besides, we generally agree on style. Anything I may
have written was more more suggestion than correction.

> Anyway, it should be that the operator goes on the first line like Ian
> says...

Feel free to use whatever style you want.

Feel free to update CodingStyle too.

cheers, Joe



\
 
 \ /
  Last update: 2014-02-25 13:41    [W:0.052 / U:3.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site