Messages in this thread | | | Subject | drm/msm: CONFIG_MSM_OCMEM? | From | Paul Bolle <> | Date | Tue, 11 Feb 2014 16:39:41 +0100 |
| |
Rob,
Commit 55459968176f ("drm/msm: add a330/apq8x74") added preprocessor checks for CONFIG_MSM_OCMEM. But I couldn't find a Kconfig symbol MSM_OCMEM (nor a preprocessor define for a macro of that name). Why were those preprocessor checks added?
Please note that lines 197-201 currently read: /* Set the OCMEM base address for A330, etc */ if (a3xx_gpu->ocmem_hdl) { gpu_write(gpu, REG_A3XX_RB_GMEM_BASE_ADDR, (unsigned int)(a3xx_gpu->ocmem_base >> 14)); }
ocmem_hdl and ocmem_base are used uninitialized here, aren't they? So it seems these lines should be wrapped with a preprocessor check for CONFIG_MSM_OCMEM too.
Paul Bolle
| |