Messages in this thread | | | Date | Sun, 07 Dec 2014 15:59:47 +0200 | From | Tanya Brokhman <> | Subject | Re: [PATCH 3/6] UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure |
| |
Hi Richard,
On 11/30/2014 1:35 PM, Richard Weinberger wrote: > If ubi_update_fastmap() fails notify the user. > This is not a hard error as ubi_update_fastmap() makes sure that upon failure > the current on-flash fastmap will no be used upon next UBI attach. > > Signed-off-by: Richard Weinberger <richard@nod.at> > --- > drivers/mtd/ubi/wl.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c > index 523d8a4..7821342 100644 > --- a/drivers/mtd/ubi/wl.c > +++ b/drivers/mtd/ubi/wl.c > @@ -657,7 +657,11 @@ again: > * refill the WL pool synchronous. */ > if (pool->used == pool->size || wl_pool->used == wl_pool->size) { > spin_unlock(&ubi->wl_lock); > - ubi_update_fastmap(ubi); > + ret = ubi_update_fastmap(ubi); > + if (ret) { > + ubi_msg(ubi, "Unable to write a new fastmap: %i", ret); > + return -ENOSPC;
Why do you fail the whole function (ubi_wl_get_peb) if fastmap update failed? Its possible that the fm_pools were refilled correctly, and the actual fastmap_write failed, so there is nothing preventing the user to get peb allocated and continue working. You invalidate the fastmap, so if powercut occurs a full scan will be performed. So its possible to allocate from fm_pools (although fastmap is not valid on disc) and try writing fastmap again when the pools filled up. I'm for the ubi_msg but against "return -ENOSPC;"
> + } > spin_lock(&ubi->wl_lock); > } > >
Thanks, Tanya Brokhman -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |