Messages in this thread | | | Date | Mon, 08 Dec 2014 11:37:25 +0200 | From | Tanya Brokhman <> | Subject | Re: [PATCH 2/6] UBI: Fastmap: Don't allocate new ubi_wl_entry objects |
| |
On 12/8/2014 11:14 AM, Richard Weinberger wrote: > Am 08.12.2014 um 09:36 schrieb Tanya Brokhman: >> On 11/30/2014 1:35 PM, Richard Weinberger wrote: >>> There is no need to allocate new ones every time, we can reuse >>> the existing ones. >>> This makes the code cleaner and more easy to follow. >>> >>> Signed-off-by: Richard Weinberger <richard@nod.at> >>> --- >>> drivers/mtd/ubi/fastmap.c | 31 +++++-------------------------- >>> drivers/mtd/ubi/wl.c | 11 +++++++---- >>> 2 files changed, 12 insertions(+), 30 deletions(-) >>> >>> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c >>> index db3defd..9507702 100644 >>> --- a/drivers/mtd/ubi/fastmap.c >>> +++ b/drivers/mtd/ubi/fastmap.c >>> @@ -1446,19 +1446,6 @@ int ubi_update_fastmap(struct ubi_device *ubi) >>> } >>> >>> new_fm->used_blocks = ubi->fm_size / ubi->leb_size; >> >> Not related to this patch, but looking at this function it got me thinking: why do we need to re-calculate new_fm->used_blocks (and check calculated value) each time? fm_size >> doesn't changed at runtime. leb_size sure does not, so fm->used_blocks can be ubi device parameter and calculated & tested only once, and not each time we write fastmap. Correct? > > If you dig deeper into the patch set you'll notice that the fastmap size can change. :-) >
oh, ok. sorry, still in the middle of the review.
> Thanks, > //richard >
Thanks, Tanya Brokhman -- Qualcomm Israel, on behalf of Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
| |