lkml.org 
[lkml]   [2014]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] Make /proc/<pid>/io world readable
On Thu, Dec 11, 2014 at 8:22 AM, Marcel Mol <marcel@mesa.nl> wrote:
> /proc/<pid>/io is only readable by the pid owner, while files
> like stat, statm and status are world readable.
> I see no reason why io statistics should be hidden.
> This patch makes io also world readable so process io counts
> can be analysed without root permissions.

I'd really rather go the other direction and leak less information to
the world by default.

If we wanted to add a general control to let admins set permissions
for proc files for new processes, that could be useful. Then admins
could set this.

--Andy

>
> Signed-off-by: Marcel Mol <marcel@mesa.nl>
> ---
> fs/proc/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 772efa4..7bd8dbe 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2563,7 +2563,7 @@ static const struct pid_entry tgid_base_stuff[] = {
> REG("coredump_filter", S_IRUGO|S_IWUSR, proc_coredump_filter_operations),
> #endif
> #ifdef CONFIG_TASK_IO_ACCOUNTING
> - ONE("io", S_IRUSR, proc_tgid_io_accounting),
> + ONE("io", S_IRUGO, proc_tgid_io_accounting),
> #endif
> #ifdef CONFIG_HARDWALL
> ONE("hardwall", S_IRUGO, proc_pid_hardwall),
> @@ -2904,7 +2904,7 @@ static const struct pid_entry tid_base_stuff[] = {
> REG("make-it-fail", S_IRUGO|S_IWUSR, proc_fault_inject_operations),
> #endif
> #ifdef CONFIG_TASK_IO_ACCOUNTING
> - ONE("io", S_IRUSR, proc_tid_io_accounting),
> + ONE("io", S_IRUGO, proc_tid_io_accounting),
> #endif
> #ifdef CONFIG_HARDWALL
> ONE("hardwall", S_IRUGO, proc_pid_hardwall),
> --
> 1.9.3
>
>



--
Andy Lutomirski
AMA Capital Management, LLC


\
 
 \ /
  Last update: 2014-12-11 19:01    [W:0.035 / U:0.544 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site