lkml.org 
[lkml]   [2014]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] rtsx_usb_ms: Use msleep_interruptible() in polling loop
From
Date
rtsx_usb_ms creates a task that mostly sleeps, but tasks in
uninterruptible sleep still contribute to the load average (for
bug-compatibility with Unix). A load average of ~1 on a system that
should be idle is somewhat alarming.

Change the sleep to be interruptible, but still ignore signals.

A better fix might be to replace this loop with a delayed work item.

References: https://bugs.debian.org/765717
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
Re-sent without the typo in linux-kernel address.

Ben.

drivers/memstick/host/rtsx_usb_ms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c
index a7282b7..7356780 100644
--- a/drivers/memstick/host/rtsx_usb_ms.c
+++ b/drivers/memstick/host/rtsx_usb_ms.c
@@ -706,7 +706,8 @@ poll_again:
if (host->eject)
break;

- msleep(1000);
+ if (msleep_interruptible(1000))
+ flush_signals(current);
}

complete(&host->detect_ms_exit);

--
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2014-11-06 03:01    [W:0.050 / U:9.060 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site