Messages in this thread | | | Date | Tue, 4 Nov 2014 22:42:58 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter |
| |
On Tue, Nov 04, 2014 at 02:32:00PM +0000, Al Viro wrote: > > Too noisy, IMO. How about skb_copy_datagram_msg() first? The fewer > places have to even think of iovec or iov_iter, the better...
We have places like tcp ucopy and tun that do not have msghdr. So doing skb_copy_datagram_msg means that we'd have to create a fake msghdr wrapper around them. The point is not everything comes in via sendmsg/recvmsg.
What is your motivation for hiding iov/iov_iter? Do you plan to change their API at some future point?
Cheers, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |