lkml.org 
[lkml]   [2014]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] macvtap: Use iovec iterators
On Thu, Nov 06, 2014 at 04:28:20PM +0800, Herbert Xu wrote:

> + if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter))
> return -EFAULT;

Again, wrong calling conventions. It returns how much has it copied.

> + ret = copy_to_iter(&veth, sizeof(veth), iter);
> + if (ret || !iov_iter_count(iter))
> goto done;
Ditto.


\
 
 \ /
  Last update: 2014-11-06 18:41    [W:0.181 / U:0.548 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site