On Thu, Nov 06, 2014 at 04:28:20PM +0800, Herbert Xu wrote:> + if (copy_to_iter(&vnet_hdr, sizeof(vnet_hdr), iter))> return -EFAULT;Again, wrong calling conventions. It returns how much has it copied.> + ret = copy_to_iter(&veth, sizeof(veth), iter);> + if (ret || !iov_iter_count(iter))> goto done;Ditto.