Messages in this thread | | | Date | Tue, 25 Nov 2014 11:32:51 +0000 | From | Mark Brown <> | Subject | Re: [PATCH v2 13/14] spi/of: Create new device registration method and accessors |
| |
On Mon, Nov 24, 2014 at 10:33:41PM +0000, Grant Likely wrote: > From: Pantelis Antoniou <pantelis.antoniou@konsulko.com> > > Dynamically inserting spi device nodes requires the use of a single > device registration method. Refactor the existing > of_register_spi_devices() to split out the core functionality for a > single device into a separate function; of_register_spi_device(). This > function will be used by the OF_DYNAMIC overlay code to make live > modifications to the tree. > > Methods to lookup a device/master using a device node are added > as well, of_find_spi_master_by_node() & of_find_spi_device_by_node(). > > Changes since v1: > * Brown paper bug with parameter on of_register_spi_device().
Please don't include things like this in the commit message, if you want to include a changelog put it after the --- like SubmittingPatches says. Once it's in mainline this is just noise.
Otherwise
Reviewed-by: Mark Brown <broonie@kernel.org> [unhandled content-type:application/pgp-signature] | |